Roman Blanco

Results 55 comments of Roman Blanco

Maybe relevant issue to pay attention to during rewrite: In some cases it happens that the `href` of [link] does not contain full path ([comments] link works correctly): ``` submitted...

@jtannas, @akofink It seems to me that the logic of this change is already covered in `master` since https://github.com/rswag/rswag/pull/507 got merged: https://github.com/rswag/rswag/blob/c0ce108905c89e68bb3ac6ba1194caf675306745/rswag-specs/lib/rswag/specs/request_factory.rb#L131-L158 Reviewing the [test results](https://github.com/rswag/rswag/actions/runs/2943789257/jobs/4701799792#step:7:18) in #521, the current...

@seliverstov-maxim I think that what you're showing is a style of Swagger UI and is not something to fix in this gem.

@amiuhle @jtannas I've cherry-picked commit from this PR and added tests in https://github.com/rswag/rswag/pull/570 to help this get merged soon.

@jtannas I think this can be closed as duplicate of https://github.com/rswag/rswag/issues/534#issuecomment-1259124187

I can break the syntax with this case: ![2021-01-26-112338](https://user-images.githubusercontent.com/1187051/105839355-4247d080-5fc9-11eb-91ad-b69edc5e0d3f.png) After removing the comparing from ternary operator, the syntax is OK: ![2021-01-26-112406](https://user-images.githubusercontent.com/1187051/105839353-41af3a00-5fc9-11eb-80d0-16d716e2de2f.png) Also seeing issues with this: ![2021-01-26-112500](https://user-images.githubusercontent.com/1187051/105839351-4116a380-5fc9-11eb-8ff8-2d0b26b79296.png) Going through changes,...

Closing, as #605 got merged. Thank you, @Zooip for starting this!

Will leave this here: https://www.openapis.org/blog/2021/02/16/migrating-from-openapi-3-0-to-3-1-0

@pboling Right, FYI, the changes dropping RSpec v2 are already commited in the [`v3`](https://github.com/rswag/rswag/compare/master...v3) branch: https://github.com/rswag/rswag/commit/31861187a47e31e653b012b09c905b1bcffb8df4

@mochetts, can you verify if this is still an issue in the latest version?