news icon indicating copy to clipboard operation
news copied to clipboard

If an article doesn't have title, there's no link to the article

Open RomanYankovsky opened this issue 5 years ago • 13 comments

Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)

Is your feature request related to a problem? Please describe. If an article doesn't have title, there's no link to the article. Technically it's there, but as the text inside <a></a> tag is empty, it's not visible and not clickable.

Describe the solution you'd like Update timestamp on the right side to make it a link to original article, or/and use a placeholder like "(no title)" when title is empty in order to make it visible and clickable.

Additional context изображение


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

RomanYankovsky avatar Aug 15 '20 18:08 RomanYankovsky

I am currently working on a frontend rewrite in vue and will fix this issue there. I dont think it is worth fixing this in the current Code

JonathanTreffler avatar Aug 16 '20 19:08 JonathanTreffler

@JonathanTreffler Do you have the issue ID for the reference?

RomanYankovsky avatar Aug 16 '20 20:08 RomanYankovsky

Yes, #748 and #195

JonathanTreffler avatar Aug 16 '20 20:08 JonathanTreffler

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Sep 07 '20 08:09 stale[bot]

Maybe relevant issue to pay attention to during rewrite:

In some cases it happens that the href of [link] does not contain full path ([comments] link works correctly):

<div class="body" news-bind-html-unsafe="item.body" ng-attr-dir="{{item.rtl &amp;&amp; 'rtl'}}" dir="false">  submitted by   
  <a target="_blank" rel="noreferrer" href="https://www.reddit.com/user/MichaelCade"> /u/MichaelCade 
  </a>   to   
  <a target="_blank" rel="noreferrer" href="https://www.reddit.com/r/kubernetes/"> r/kubernetes </a>
  <br>
  <span><a target="_blank" rel="noreferrer" href="/r/Kasten/comments/lsw4bq/building_the_home_lab_kubernetes_playground_part_2/">[link]</a></span>
  <span><a target="_blank" rel="noreferrer" href="https://www.reddit.com/r/kubernetes/comments/lsw54e/building_the_home_lab_kubernetes_playground_part_2/">[comments]</a></span>
</div>
  • Nextcloud 20.0.4
  • PHP Version: 7.4.13
  • Database Type: mysql Version: 10.5.8

romanblanco avatar Feb 27 '21 11:02 romanblanco

In some cases it happens that the href of [link] does not contain full path ([comments] link works correctly):

I suggested a solution here: https://github.com/nextcloud/news/issues/1952 & https://github.com/nextcloud/news/pull/2100

IgorA100 avatar Feb 14 '23 06:02 IgorA100

Duplicate of https://github.com/nextcloud/news/issues/2037?

uncovery avatar Feb 23 '23 02:02 uncovery

This has become an issue for Mastodon feeds, since they've removed their titles: https://github.com/mastodon/mastodon/pull/18640

LinAGKar avatar Jun 20 '23 07:06 LinAGKar

Yea that's very unfortunate, there has been no movement on the front-end part unfortunately.

And as the frontend works even less with the recently released Nextcloud 27. We are considering removing the frontend completely..

Grotax avatar Jun 20 '23 10:06 Grotax

Is this fixed in the new frontend @Grotax ?

SMillerDev avatar Oct 28 '23 21:10 SMillerDev

No idea, haven't seen such a feed yet. Without an example it's hard to tell what would happen.

Grotax avatar Oct 29 '23 06:10 Grotax

I will check when I have time.

Grotax avatar Oct 29 '23 06:10 Grotax

Not fully fixed, the Feeds from Mastodon for example do not provide a title at all. So the field in the DB is null. In the new frontend, there is simply nothing then. But it can handle it. There is still the icon to open the website and nothing breaks.

I guess some improvement could still be made here, to display something there and link it to the url of the item.

In the DB the field should still be null since it reflects the feed as is.

For other case idk, we need example feeds.

Grotax avatar Oct 29 '23 07:10 Grotax