romalytvynenko
romalytvynenko
@DarKsandr please add a test.
@DarKsandr I'm still hesitant about the solution because the original issue may be solved once static analysis for rules are introduced. I'll return to this soon
@DarKsandr it will! With simple `array_merge` support, all the PHPDoc annotations will be analyzed.
Closing in favor of future static analysis based solution
@alanstriglio are you using the latest version (0.11.14)?
@alanstriglio try the latest. If problem persists, reopen the issue.
@darkbasic thanks for more explanation. Indeed, this is a valid JSON Schema and type generator should've handled it properly. So I'm closing the issue for now.
Great catch! Do you have ideas how the proper JSON schema should look like to describe the file size? I couldn't find the answer
@jbrooksuk @NeikiDev looking into it!
Speaking of API documentation, I fixed the issue with Scramble documenting `update` endpoint: https://github.com/cachethq/core/pull/258 By the way, `MetricPointController@update` method is registered here hence it was added to API documentation: https://github.com/cachethq/core/blob/117787672da2cc91ad6d465ce35f41b4d2dc4062/routes/api.php#L61-L63...