romalytvynenko

Results 124 comments of romalytvynenko

@hosni > Then, in [src/Support/OperationExtensions/ParameterExtractor/TypeBasedRulesDocumentationRetriever.php](https://github.com/dedoc/scramble/blob/v0.12.35/src/Support/OperationExtensions/ParameterExtractor/TypeBasedRulesDocumentationRetriever.php#L36), the method getDocNodes() ignores such entries because of this check You can check the source of `getArrayItemKey` – such entries are not ignored due to...

@hn-seoai this is indeed something to be thought off. Please wait before working on it, as I'm still thinking about the solution

@korridor @hn-seoai @horlarme Just to be clear, I agree this is the real issue and needs to be addressed. Thanks for raising the issue

Closing this PR, as the issue is fixed by this one: https://github.com/dedoc/scramble/pull/570 Thanks!

@james2doyle looking good! In the latest version, I've introduced a simpler option to implement such extension: https://github.com/dedoc/scramble/blob/main/src/Support/InferExtensions/ArrayMergeReturnTypeExtension.php Going forward, this is the preferred way

@james2doyle I'm open to accept redirect helper support when implemented using that new approach. Feel free to either modify this PR, or close this one and open a new one.

Closing this PR as waiting for implementation that uses something like this: https://github.com/dedoc/scramble/blob/main/src/Support/InferExtensions/ArrayMergeReturnTypeExtension.php

@petert82 cannot reproduce in 0.13.3, maybe it was fixed along the way. Let me know if the issue persists for you on the newest version.

@m4tthumphrey what is the correct result?

@m4tthumphrey redirect is simply a response with 301 status code. Perfectly valid http stuff, I'd say :-) Now I'm wondering about this controllers method code and what it does, and...