scramble icon indicating copy to clipboard operation
scramble copied to clipboard

Multiple requests #468

Open DarKsandr opened this issue 1 year ago • 4 comments

https://github.com/dedoc/scramble/issues/468

DarKsandr avatar Aug 01 '24 04:08 DarKsandr

Снимок экрана от 2024-08-01 07-42-12 Снимок экрана от 2024-08-01 07-41-58

DarKsandr avatar Aug 01 '24 04:08 DarKsandr

@DarKsandr please add a test.

romalytvynenko avatar Aug 01 '24 06:08 romalytvynenko

@romalytvynenko Is this enough? I'm not very good at testing

DarKsandr avatar Aug 01 '24 06:08 DarKsandr

@romalytvynenko are there any problems with the task?

DarKsandr avatar Aug 06 '24 18:08 DarKsandr

@DarKsandr I'm still hesitant about the solution because the original issue may be solved once static analysis for rules are introduced. I'll return to this soon

romalytvynenko avatar Aug 16 '24 07:08 romalytvynenko

@romalytvynenko unfortunately static analysis will not solve the problem of multiple requests unless you combine them into one

DarKsandr avatar Aug 16 '24 07:08 DarKsandr

@DarKsandr it will! With simple array_merge support, all the PHPDoc annotations will be analyzed.

romalytvynenko avatar Aug 16 '24 07:08 romalytvynenko

Closing in favor of future static analysis based solution

romalytvynenko avatar Sep 15 '24 10:09 romalytvynenko