Rokas Kupstys
Rokas Kupstys
> I made in the code/commit itself as an experiment in reviewing but I'm thinking perhaps proper paragraph would be more helpful. In-code comments are awesome, please keep doing that...
I was thinking and thinking and thinking about this and came to a conclusion that this PR is no good. Proposed helper API implements a terrible UX for reordering. My...
> perhaps the reorder target could be taller, overlapping previous and subsequent item. > the reorder target perhaps should just be a thick line instead of a rectangle? These are...
Hey @AnimatorJeroen. This is more of a proof of concept. I am not sure it is a right way to do reordering. No idea if we are going to rework...
You should not replace files like that. You should either use all files from [my branch](https://github.com/rokups/imgui/tree/reorder-api) or apply changes from this PR manually. Replacing half of library with older versions...
I updated first post detailing rework pushed to the branch of this PR. Rework is quite different from initially proposed code so please read first post again. Previous code has...
> 1. Textures may have to be uploaded in _Render (to support dynamic glyphs). Incremental atlas baking branch i am working on updates font atlas texture outside of imgui frame....
Turns out rasterizing glyphs immediately wasnt that big of a deal. I am not quite sure if locking font atlas during frame is warranted. It rebuilds just fine, granted it...
 ```cpp static char input[32]{""}; ImGui::InputText("##input", input, sizeof(input)); ImGui::SameLine(); static bool isOpen = false; bool isFocused = ImGui::IsItemFocused(); isOpen |= ImGui::IsItemActive(); if (isOpen) { ImGui::SetNextWindowPos({ImGui::GetItemRectMin().x, ImGui::GetItemRectMax().y}); ImGui::SetNextWindowSize({ImGui::GetItemRectSize().x, 0}); if (ImGui::Begin("##popup",...
`sdl(2)-config` produces include path with `../SDL(2)` on all platforms (including macports too). Seems to me this is a convention to be followed. Preferring `SDL2/SDL.h` over `SDL.h` would definitely break projects...