Rokas Kupstys
Rokas Kupstys
Make sure dialog asking to save scene does not spawn behind editor window.
I see we will have to chose one of the three configurations: * Use OpenAL as shared library (even if rest of build is static) (open source, closed source on...
Rebase your branch on to https://github.com/rokups/rbfx/tree/rk/openal, OpenAL/MojoAL already linked into Urho3D target. I did not investigate OpenAL availability on platforms like MacOS etc. We can look into it later.
A little update. We decided against including entire OpenAL in ThirdParty dir and left only MojoAL. What does that mean: * Engine remains 100% free of any restrictions by default...
Make sure you add comments informing that this is our custom change so we do not lose them next time MojoAL is updated.
Oh looks like i did not make these changes in time. You should rebase your branch on to `rokups:rk/openal` and force-push into `tatjam:openal`. Sorry for making it messy for you
actually could you make it `rbfx` instead of `tatjam`? it is hard to remember names of all contributors and we may mistake it for official MojoAL content.
Btw i pushed one more fix to rk/openal so you might want to rebase on that. Also make sure you lose `ThirdParty/OpenAl` dir as i see it is still in...
> target_link_libraries(Urho3D PUBLIC ${OPENAL_LIBRARY}) You are right! And `${OPENAL_LIBRARY}` should be removed from thirdparty dependencies array. I made a mistake there.
Hey @tatjam, how is this PR going? Do you consider it mostly done or is there any pending work that you had no time for?