Roger Peppe
Roger Peppe
A standard idiom for enumerators seems to have emerged [1],[2], which makes for quite nice looking code. Perhaps consider using that here. Something like this perhaps? ``` type Enumerator struct...
In JSON, the Unicode characters with code points 0x7f to 0xff can be encoded either as those characters directly, or with a Unicode escape sequence (e.g. `\u00ff`). As such, JSON...
Currently if we get an error from the registry, we cache it for all time. We could instead inspect the error and cache the result only if it's not marked...
Currently the top level type for generated code must be a record. It would be good if it could be other types too (most importantly a union type). The main...
If there's more data in the buffer than needed, Unmarshal will succeed, but it should probably fail.
The Confluent Avro registry produces very uninformative error messages. For example, when trying to upload an incompatible schema to a subject, the returned error says nothing about _why_ the schema...
The code to derive a default value from a Go struct is too naive. It doesn't cope when the JSON-formatted value isn't correct for Avro. Here's a test case that...
Currently `avrogo` will never generate the type definitions if they have a `go.package` field, but that's not what we want if we're generating the types within that package itself.
There are still quite a few holes in the testing: - out of bounds cases - fuzzing - zero length byte read - zero length string read - many error...
This code panics because the `newAzTypeInfo` code doesn't recognize that a non-record type might have entries. ``` type R struct { A int } avro.Marshal(&R{13}) ``` ```--- FAIL: TestGoTypeEncodeWithPointer (0.00s)...