Roger Peppe

Results 283 comments of Roger Peppe

@aarzilli Thanks. That's useful, but I still think that it would be good to be able to copy arbitrary pieces of text that are displayed (for example memory addresses), and...

#184 is about provider functions, not cleanup functions. We can already have anonymous cleanup functions: func newFoo(a *A, b *B) (*somePkg.Foo, func(), error) { foo, err := somePkg.NewFoo() if err...

@vangent AFAICS that's exactly the approach that I alluded to in the issue description: > This means it's always necessary to add an adaptor function that returns a cleanup function...

Yes, but it's not just about efficiency. One of the selling points of wire is that the generated is a readable representation of the dependency setup. This is one thing...

One standard way to do this is `TERM=dumb`. It would be great if that setting disabled all ANSI tty output.

To go into a bit more detail on this: The confita README says: > Confita scans a struct for config tags and calls all the backends one after another until...

I like `SortSlices` because it also functions as a good way of displaying differences coherently with `cmp.Diff`. With `cmpopts.IgnoreOrder`, what would `cmp.Diff` print when there's a difference? For semantics, how...

> IgnoreOrder could work by sorting, so it could produce good diffs. The docs could even say as much. If that's the case, then I don't really see that spelling...

> Using a map as the output implies set, not multi-set. Other than that, I think that something like a reasonable idea. Unfortunately, I think that's a show stopper in...

That code doesn't implement the dedup parameter, though it wouldn't be hard. I actually quite like your idea of using maps rather than defining a generic less function. Here's another...