Roger Peppe

Results 283 comments of Roger Peppe

Thanks very much for this. AFAICS it allows multiple tags to be specified too. As a possible addition or alternative to this, what do you think about the possibility of...

I just came across this problem and found this issue, so am replying here. > The special treatment of /api would have to be done within the registered handler (can...

I like it the way it is. With closures, it's already plenty flexible enough IMHO.

Another thought: if httprouter mirrored the http package and used a Handler type instead of the Handle function type: type Handler interface { ServeHTTPRoute(http.RequestWriter, *http.Request, Params) } and the underlying...

I think this is correct. I've never needed B.C to match A.B.C when writing `gofmt -r` expressions, and I think it's useful that it doesn't because I don't think I...

Yeah, that's an interesting point. It applies to type aliases too. For example we might do: gogrep 'http.Request' but that won't find places that it's mentioned via a type alias...

Yeah, I've had the same thoughts. The main question to my mind is whether we'd want strict mode to be a global, or whether it would be more useful to...

Oh, that's an excellent point. That means we definitely need a global flag, and that's fine. The `$

One possibility for a type restriction might be `someExpr.$(type)` - reminiscent of Go's .() syntax but for arbitrary nodes. Initially I wondered if it might feel potentially awkwardly ambiguous with...

> Maybe we should come back to this once we encounter it. +1