Roderick van Domburg
Roderick van Domburg
Sorry, hit the wrong button adding all the review comments individually. Let me know if this is acceptable for you to work on before merging. Would also be great if...
Let's keep it constructive. I've seen the code before the link was deleted because Spotify told us to. And they could because it was a decompiled version, which is not...
@colinmarc new maintainer here and doing backlog grooming. So sorry this did not get picked up before, because it seems very worthwhile! Would you be so kind to resolve the...
Wow, amazing turnaround time! 👍 Coming weeks I don't have access to a machine to test it myself, which, as much I believe you 😉 I would like to do....
Superseded by #1011 based on this work. Thanks!
@abique doing backlog grooming as new maintainer. Yes the current calculation is off and your proposal is better. I'm just thinking that the period size could be even more optimally...
Understood. Apologies for the late response and thank you for your earlier efforts 🙏
Superseded by #990
For the record, which version of librespot? 0.4? dev? Those downstream packages use 0.4 I presume. Please try them both. I remember I made some changes on it to dev....
Given it's working on Windows, what if you change this line: https://github.com/librespot-org/librespot/blob/299b7dec20b45b9fa19a4a46252079e8a8b7a8ba/core/src/connection/mod.rs#L91 To pretend that it's always Windows? You may need to do the same here: https://github.com/librespot-org/librespot/blob/299b7dec20b45b9fa19a4a46252079e8a8b7a8ba/core/src/connection/handshake.rs#L113 Then in `dev`...