Roderick van Domburg

Results 376 comments of Roderick van Domburg

It sometimes happens that the packet isn’t received fully. I thought I had made that piece of the code panic-free but I guess I missed something.

Other than that it would be nice to make it panic-free, I see at the beginning of the log that it fails to bind, that the address is already in...

Feel free to submit a PR. As with other project, let’s make it feature-gated to give users the choice.

> The [Authentication doc](https://github.com/librespot-org/librespot/blob/dev/docs/authentication.md) seems a bit outdated. Yes, I am afraid this is true for most of the documentation. > I think it would be good to list each...

I cannot say with certainty as I have never tried myself. But it is what I gather also from the unfinished effort over at https://github.com/librespot-org/librespot-java/pull/446. I have some doubts whether...

That's a pretty old version that we no longer support. Please update to the latest 0.4.x (release) or 0.5.x (dev).

Appreciate the work! I don’t have a lot of time and as you know I don’t use this anymore myself, so I hope others will take a look before I...

> The portaudio, jackaudio and rodio backends need tested and probably fixed. I'm not really at all familiar with them. The ALSA and PulseAudio backends are solid. Gstreamer was super...

> Maybe we can convert that in librespot to present the actual error message (useless as it is anyway)? Sure do it. One tip, forget about trying to deserialize the...

Does your resampler have an anti-aliasing filter?