Chris Roche

Results 88 comments of Chris Roche

Thanks for the info! I have no complaints here, but defer to @akonradi or someone more experienced with Bazel to comment.

Hey! protoc plugins cannot see the configuration for other plugins, so validate_out can't see the M params on go_out. You need to repeat the M options onto the valdiate_out flag....

Many of the [WKTs](https://github.com/envoyproxy/protoc-gen-validate#well-known-types-wkts) are covered (including `google.protobuf.Timestamp`), but I'm hesitant to suggest adding support for these other types as it's another dependency. The `google.protobuf.*` WKTs are almost always bundled...

PGV is a binary and doesn't expose any runtime dependencies for Go; there's not really anything here to import wrt Go. I'm curious, can you tell me why you are...

I think it's worth pinning a minimum version for these up to a major release (assuming our deps are following semver).

@dkunitsk, would you be able to provide some clarity here?

Hey, go for it! You may be able to get the module version at runtime using https://pkg.go.dev/runtime/debug#ReadBuildInfo

> Is there any way to have a string with semantic versioning directly available in the code instead of relying on runtime introspection? I'm concerned about whether or not the...

Hey, thanks for the report! Would be helpful to have a (reduced) example of these protos. Otherwise, it's hard to distinguish what's happening here.

I believe there's interest internally at Lyft to have this prioritized. @ccaraman is this on your team's plate?