protoc-gen-validate icon indicating copy to clipboard operation
protoc-gen-validate copied to clipboard

Update request, Python example

Open Prideauxx opened this issue 4 years ago • 12 comments

The Python example as described in README.md appears incomplete. Please consider fleshing it out more using the given Persons 'example.proto', also from README.md. I spent just over a day working with reversing the bazel test scripts to put something functional together--I'm still not quite there. From a somewhat experienced (non-neophyte) developer's point of view, this has been more difficult than it needs to be.

I'd love to contribute to this project--I see it fulfilling a need I've not seen elsewhere. The reason I chose the Python implementation over Go/C++ was to share findings with colleagues in a straightforward manner (they seem to know Python and there is a level of comfort in it). Although perhaps not the most performant, there is definite value in supporting Python here, as others likely feel the same.

I'm going to spend another day on getting the Python example working; from there I'll likely try other implementation approaches before throwing in the towel.

Prideauxx avatar Jun 09 '20 11:06 Prideauxx

+1 on this, it would be great to have a fully working example in Python.

adriangb avatar Jul 07 '20 17:07 adriangb

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 08 '20 02:08 stale[bot]

I think this is not stale, it just hasn't gotten a reply, sorry stale bot.

adriangb avatar Aug 15 '20 19:08 adriangb

I'm happy to review PRs!

akonradi avatar Aug 20 '20 13:08 akonradi

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 20 '20 04:09 stale[bot]

hello,

i have a proto repo and my task is to generate a some python files containing the protos, grpc and validators for another team. i'm struggling using validate with python and would love to see some complete example.

for now i'm trying to make the comment in #368 work, while not sure which commenter got it right...

thank you

buzzdan avatar Oct 25 '20 11:10 buzzdan

as part of PR #433 , an easy to use example is now updated in the main README: https://github.com/envoyproxy/protoc-gen-validate/#python

buzzdan avatar Mar 16 '21 08:03 buzzdan

ok just found out this issue is still a problem (see my last comment on #368 ) still need a full example of how to make it work:

  • add validations to proto
  • generate python stubs
  • add unit test with PGV
  • see it work

buzzdan avatar Mar 22 '21 13:03 buzzdan

Maybe #255 is a good lead to solve this issue...

buzzdan avatar May 20 '21 21:05 buzzdan

related: https://github.com/envoyproxy/protoc-gen-validate/issues/368#issuecomment-855388992

buzzdan avatar Jun 06 '21 12:06 buzzdan

Hi, thanks for maintaining this package. It looks awesome. However, I am too struggling to get the Python support working. I've been struggling with it for two days, and I can't figure out how to perform the entire flow as described in this comment. I've also reviewed all the related PRs and the README, and I still can't get it to work, and I'm not sure what I'm missing.

estiller avatar Dec 13 '21 01:12 estiller

@dkunitsk, would you be able to provide some clarity here?

rodaine avatar Dec 13 '21 22:12 rodaine

As explained in the README, this project is in maintenance mode. We recommend upgrading to protovalidate.

I'm going to go ahead and close this issue, but feel free to open one against protovalidate if needed. Thanks!

chrispine avatar Feb 29 '24 19:02 chrispine