Rob Shakir
Rob Shakir
If you define an `Equal` method for `Binary` as in https://go.dev/play/p/MPwL_KjXQOF then you can use `cmp.Equal` without any other arguments. `cmp` will use an `Equal` method for a type if...
We actually already implemented this -- see https://github.com/openconfig/ygot/blob/a776802e8a810a2f41a9cd3a8bb567c800e16a51/docs/protobuf_getting_started.md You can use the `-go_package_name` flag to `proto_generator` and it will add the relevant annotation. HTH! r.
How I've interpreted this elsewhere has been that we should parse according to the order in the YANG schema. If someone writes: ```yang leaf a { type union { type...
We started the work to convert between the generated Go structs and Protobufs, which is also described in [this document](https://docs.google.com/document/d/106Qyw9Zre0kr7Gl3Xfkl4hYQv1Ml1GlTL3XsfcvOBKM/edit#heading=h.tg7bold3mrjq). Currently, there's some outstanding work to be completed here. PRs...
To diff two generated structs you can use [`ygot.Diff`](https://godoc.org/github.com/openconfig/ygot/ygot#Diff). It outputs the diff between two Go structs that were generated by `ygot` using a series of gNMI `Notification` messages to...
`New...` methods indeed do not have something that covers this use case if `CompressOCPaths` is not enabled. It would be possible to implement this relatively trivially, particularly by: * Checking...
Wen, There's a slight difference here -- we expect that creating a new entry `eth0` under `/interfaces/interface`, then we create (in the YANG schema): * `/interfaces/interface/name` = `eth0` * `/interfaces/interface/config/name`...
Wen, is this change defunct at this point -- or should we try and merge it?
Thanks @wenovus - this LGTM. Comments are minor here, but please accept the suggestions just for code style reasons :-)
The `config` element in the path isn't something that can be relied on -- since the merge needs to be able to deal with non-OpenConfig elements. I think that you're...