Rob Shakir

Results 387 comments of Rob Shakir

hi, There isn't currently a plan to add presence support to ygot. I'd be happy to review a patch for this though. I suggest that the easiest way to do...

we agreed that: * we should key `ParsedDirectory` on a fully-module qualified path - i.e., `module-a:container/module-b:container` since this makes the IR robust to any scenario (augment etc.) that can have...

Looking at this, I think this is actually better to restructure the other way around than I suggested initially. So - we'd internally restructure the code to be able to...

https://github.com/openconfig/ygot/commit/bc8585c6386371a65faf44f88547175e2561211f is a start at this restructuring - it looks fairly large in terms of a change, but I think we're actually doing OK here, and the test coverage is...

Thanks for the thoughts here -- as I've been through the few attempts at figuring this out over the last few days, this comment, and one that you made last...

I pushed to https://github.com/openconfig/ygot/tree/restruct-ygen-interface the diff size for this (including updating tests is +3170, -1732. To split this out, I think the plan is likely: * Make the changes to...

> So a few proposals to reduce the complexity of the design as well as to allow for custom user passes: > > * All code should be put into...

There's a trade-off here, that we discussed in the original ygot design. Particularly, for re-use: - ✅ Minimises the generated code. - ✅ Allows handling common containers using generic handling...

Hi, This module doesn't conform to the rules that are specified by the OpenConfig style guide -- therefore using `-compress_paths` will result in undefined behaviour. Please see the documentation [here](https://github.com/openconfig/ygot/blob/master/docs/design.md#openconfig-path-compression)....

There was the intention to make the default value of an enumeration be the 0 value in the case that a default was specified for the leaf -- is that...