Sam O'Brien

Results 23 comments of Sam O'Brien

Fixed by #491 The following passes ```rust mod issue_420 { use logos::Logos; #[derive(Logos, Debug, PartialEq)] #[logos(skip r".|[\r\n]")] // skip everything not recognized pub enum LogosToken

Fixed by #491 The following compiles and passes ```rust mod issue_456 { use logos::Logos; #[derive(Debug, PartialEq, Logos)] enum Tok { #[regex("a|a*b")] T, } #[test] fn main() { let lex =...

Fixed by #491 The following passes ```rust mod issue_399 { use logos::Logos; #[derive(Logos, Debug, Clone, Copy, PartialEq, Eq, Hash)] #[logos(skip "[ \t\r\n]+")] pub enum TokenKind2 { #[regex(r"/dts-v1")] DtsV1, // Removing...

Fixed in #491, the supplied code is now rejected because 1. It has a greedy dot repetition 2. It can have a zero length match

Fixed by #491 The following passes ```rust mod issue_478 { use logos::{Logos, SpannedIter}; #[derive(Logos, Debug, Clone, PartialEq)] pub enum Token { #[token("-")] Sub, #[regex(r"[0-9]+", |output| { output.slice().parse::().ok() })] IntLiteral(i64), #[regex(r"([+-]?(([0-9]+[eE][+-]?[0-9]+)|([0-9]*\.[0-9]+[eE][+-]?[0-9]+|[0-9]*\.[0-9]+)))",...

> Just checking: is it by any chance compatible with #491? @robot-rover Just checked; when I apply the two lines of change all the tests still pass, so it seems...

> Hi @robot-rover, looks like this PR might be conflicting with yours, or resolving the same issues. Could you check if you PR fixes the issues linked here? I'm considering...

Solved by #491, it compiles succesfully now.

Fixed by #491, the provided example no longer exhibits a stackoverflow.

I'll add that your provided code still has errors in it. Your `MultiLineComment` regex is wrong because the part that matches a `*` inside a multi line comment can match...