updating Context backtrack for new leaf misses.

[martin-juhlin]

when matching similary pattern, this will update the Content::backtrack to incoming nodes miss value, if the miss is pointing to a leaf node, meaning if somehting fail later on, it can go expected value.

adding some new test cases to verify that the new logic is working.

[codspeed-hq[bot]]

CodSpeed Performance Report

Merging #482 will not alter performance

_{Comparing martin-juhlin:master (c1b1e44) with master (8b1baf9)}

Summary

✅ 6 untouched benchmarks

[codecov[bot]]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 62.27%. Comparing base (96765c0) to head (c1b1e44). :warning: Report is 122 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #482       +/-   ##
===========================================
+ Coverage   49.15%   62.27%   +13.11%     
===========================================
  Files          33       35        +2     
  Lines        2079     2330      +251     
===========================================
+ Hits         1022     1451      +429     
+ Misses       1057      879      -178     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jeertmans]

Hi @martin-juhlin, would you mind rebasing your branch to be in sync with master? I just fixed the issue that was blocking tests from running :-)

[martin-juhlin]

HI, @jeertmans, sure, no problem. I done an update :)

[jeertmans]

Looks like your PR fixes way more issues than anticipated! I tested and it also fixes #279. That might be worth checking all issues that are fixed by the long-running issue, but it can also take some time ^^'

Anyway, happy you came up with a solution!

[jeertmans]

Might also fix #265 and #420, tbd

[LunarLambda]

Is there anything that's blocking this PR from being merged?

[jeertmans]

Not really blocking, I was just hoping we could invest some more time and test if other issues can be closed thanks to this fix.

I would really appreciate it if someone could, for each of the bugs, check if that bug can solved by this PR and, if so, write a test that shows that the bug is now fixed. Similar to what is done here, but only for 3 issues.

[LunarLambda]

I see. What about publishing a pre-release version with this merged so we can ask the authors of said issues if they can update to the pre-release and if that fixes things / changes the behaviour? Might speed up the process.

[jeertmans]

I see. What about publishing a pre-release version with this merged so we can ask the authors of said issues if they can update to the pre-release and if that fixes things / changes the behaviour? Might speed up the process.

Hmm I don't have much time to spend on this, and not enough to, so I fear I would just forget about it or postpone this. I would prefer addressing this issue now ^^'

[jeertmans]

Hi @robot-rover, looks like this PR might be conflicting with yours, or resolving the same issues. Could you check if you PR fixes the issues linked here? I'm considering closing this PR, as it may be superseded by yours, but wanted to check this with you. I see you commented on #160, but what about #265, #279, and #481?

[robot-rover]

Hi @robot-rover, looks like this PR might be conflicting with yours, or resolving the same issues. Could you check if you PR fixes the issues linked here? I'm considering closing this PR, as it may be superseded by yours, but wanted to check this with you. I see you commented on #160, but what about #265, #279, and #481?

Yes, it looks like #491 solves all of those issues, so I think this can be closed.

[jeertmans]

Closing as superseded by #491