Robin Stocker

Results 123 comments of Robin Stocker

Yeah it would be useful, but I've been hesitant to commit to an API for it before (in order not to have to break API if we need to change...

Hey! Thanks for picking this up :). So, a couple of thoughts: * I think `Link` itself should be the name of the interface (not `GenericLink`) * `Link` should be...

Yeah, I see what you're saying. I think the `ReferenceLink` would have `foo` as child node(s). But it would also be useful to just have a String representation of it,...

The first part of this is now done, see cb43ae9.

Hey! Just wanted to let you know that I haven't gotten around to review this yet, but it sounds promising :)! > Use of IncludeSourceSpans.BLOCKS_AND_INLINES is recommended for 100% Commonmark...

Hey. Can you go into a bit more detail why you want that? I'm not sure the option is the best way to solve it. E.g., for markdown like this:...

Note that you can already achieve this with the current API. What you have to do is after parsing, change the nodes from a structure like this: * document *...

> Are you saying that libraries/apps that consume CommonMark should be aware of the HTML/DOM that is being generated and manipulate it accordingly? They have to be aware of the...

@dustindclark How about you raise a PR to implement it? I'm curious what it would look like, and if we have code with tests it's much easier to talk about....

Yep, the autolink extension currently doesn't handle source positions correctly, that's a bug. The fix needs to be made somewhere here, along with tests: https://github.com/commonmark/commonmark-java/blob/main/commonmark-ext-autolink/src/main/java/org/commonmark/ext/autolink/internal/AutolinkPostProcessor.java#L34 I'll try to get a...