Robin Stocker

Results 144 comments of Robin Stocker

I've raised a PR to fix yaml-rust: https://github.com/chyh1990/yaml-rust/pull/122 Unfortunately it looks like yaml-rust is not actively maintained. Should we: 1. Regenerate the packs with the fix but keep the yaml...

Good news, my fix was merged and [yaml-rust 0.4.3](https://crates.io/crates/yaml-rust) was released, we don't need to fork :). But there's another problem, with the Python syntax: ``` Running `target/debug/examples/gendata synpack testdata/Packages...

Hmm, that looks like a similar problem, but I'm not sure it's the same. In our case, we only have a `(?x:...)`, not a bare `(?x)...`

You were right! So: 1. `\b*` does *not* result in an error in Sublime Text's regex engine 2. An included pattern is *not* implicitly wrapped in `(?-x: ...)`, e.g. this:...

PR: https://github.com/sublimehq/Packages/pull/1897

Raised a PR with the updates here: #246

> cc @robinst any thoughts on what might needed to be added to either the rewriter or fancy-regex to fix these and guesses as to how much work it would...

@Keats Published version 0.3.4 now: https://github.com/fancy-regex/fancy-regex/blob/master/CHANGELOG.md#034---2020-04-28 Note that it's unlikely that I'll implement `\g` for [subexp calls](https://github.com/kkos/oniguruma/blob/master/doc/RE#L451) in the near future. I would recommend replacing them with `{{variable}}` references instead....

Also created a PR to make error messages include what the unknown flag/escape is: https://github.com/fancy-regex/fancy-regex/pull/46

Released https://github.com/fancy-regex/fancy-regex/pull/46 as 0.3.5