Robin Stocker
Robin Stocker
Alright, I've created a minimal repo to reproduce here: https://github.com/robinst/test-doc-comment Can you clone and run `cargo test` and see if it succeeds or fails? My Rust version is 1.47.0 if...
Doesn't help: https://github.com/robinst/test-doc-comment/commit/8ac8c8feb96c7c2567a351f8214aa0bc55552177 Note, adding this to `tests/readme.rs` doesn't make it fail either: ``` /// ``` /// assert_eq!("foo", "bar"); /// ``` fn foo() {} ``` So I think the problem...
Done: https://github.com/rust-lang/rust/issues/79587 But also, I think the docs for this crate (doc-comment) should mention it as well.
Looks like the fix for this was released with libgit2 v1.8.0 (released 3 weeks ago): https://github.com/libgit2/libgit2/releases/tag/v1.8.0 Now this is blocked on the rust bindings: - https://github.com/rust-lang/git2-rs/pull/1032
PR is ready now: - https://github.com/commonmark/commonmark-java/pull/332 I've also found some interesting edge cases that GitHub doesn't handle well, see https://github.com/commonmark/commonmark-java/pull/332#issuecomment-2212453622 :)
Spot on, see the docs for `addFrame`: https://taglib.org/api/classTagLib_1_1ID3v2_1_1Tag.html#ae090718d9acff1341530aa6438759b40 > Add a frame to the tag. At this point the tag takes ownership of the frame and will handle freeing its...
Interesting. What might help narrowing it down is to see if any of the specific TagLib functionality triggers it. E.g. if you remove `from_string_list` and use a different tag, can...
Also, reading through the [Ruby 3.2 release notes](https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/), it looks like YJIT is now enabled by default? Does the problem also occur if you disable it on 3.2 (not sure...
Thanks for raising. I haven't looked at the breaking changes yet. Maybe we can release a 2.0.0 that requires taglib 2.0, and if necessary release 1.x versions that still work...
Yeah. I think the first step is going to be to get the CI build set up to use taglib 2. I've started that here: * https://github.com/robinst/taglib-ruby/pull/129 Note that it...