Robin Stocker comments

Results 183 comments of


                                            Robin Stocker

Version 0.13.0 throws an Error::BacktrackLimitExceeded

I had a look at the first example by @jcold. The difference seems to be caused by the `\b` for that one: ``` $ git switch --detach 0.12.0 $ cargo...

Thanks! From the docs it looks like if there's a maven wrapper it will use that version: https://jitpack.io/docs/BUILDING/#maven-projects Can you try adding maven wrapper instead of a custom configuration file?...

Fix JitPack builds

@zampino Thanks. > could you consider merging main into the footnotes branch(es) afterwards? Done!

Internal space line is trimmed in converted plaintext

The plain text renderer is not really well-defined. But this is something we might change (CC @JinneeJ). Out of interest, what are you using it for?

Internal space line is trimmed in converted plaintext

Ah this came up in https://github.com/commonmark/commonmark-java/issues/264 as well. Happy to accept a patch for this as an option on `TextContentRenderer.Builder`.

Internal space line is trimmed in converted plaintext

Closing as a duplicate of #264

Footnotes extension

I've found some interesting behaviors (bugs) in GitHub's implementation while working on this. E.g.: ``` [^1]: One [^2] [^2]: Two ``` That shouldn't render anything, because only 2 is referenced...

`find_iter()` stuck in infinite loop after `Error::BacktrackLimitExceeded` occurs

Hm yeah I see how that can be confusing. And re-attempting the match at the same position doesn't make sense anyway, as it will fail again. I think there's two...

When there is only one "\n", the table header cannot be recognized.

A more minimal example of what this is about (I believe): ``` text |a | |---| |b | ``` GitHub renders it as a paragraph and a table, commonmark-java just...