Rob Figueiredo

Results 101 comments of Rob Figueiredo

Thank you for the description and reproducer! I don't have a lot of knowledge about platform handling, but I have a few questions after taking a quick look - *...

> The documentation for building pure binaries shows an example of using pure = "on' with goarch and goos set to auto. [2] which doesn't work. Maybe there's a misunderstanding.....

I don't think `--compiler=some_invalid_compiler` is a valid way to determine whether cgo is enabled or not. ``` $ rm .bazelrc # clear platform overrides $ bazel build -s //:pure_auto_auto SUBCOMMAND:...

Sure, that change sounds strictly positive to me. Thanks

This seems likely to be a dupe of https://github.com/bazelbuild/rules_go/issues/2927. Any assistance with the analysis and a PR would be much appreciated! Thanks for the report

There has been no work planned on our end, and Jay is on sabbatical for a while. If @noahdietz has the bandwidth, I'd be happy to review and contribute in...

Thanks for the fix! Is it feasible to augment the bindata test in tests/legacy/examples/bindata/ so that it would detect this problem, to avoid regressions?

> BTW, I can manually change the deps = to have the @org_golang_google_genproto// dependency rather than the @go_googleapis// one for my own PBs (and add a # keep marker on...

No, that's what I would have tried. I don't personally use `go_proto_library`, so it sounds like I was mistaken that resolve would solve this, sorry! It does sound like completing...

Thanks for the pointers. So you're saying that V8 itself does not deal with ES Modules and expects to be handed JS to execute after all the module stuff has...