Rob Figueiredo

Results 127 comments of Rob Figueiredo

Reopening to link with a pull request

1. Yes, the import and describe were from the same file (mediumpicker_test.js). In case it matters, it's an ES6 module, not goog.module. 2. Here's what the imported file looks like:...

OK, thanks for checking for smoking guns. Replacing the imported file with ``` // mediumpicker.js export default function MediumPicker() {} export function getKey() {}; export function AvailableItems() {} export function...

I'm assuming that this is in the Compiler based on the trace, but it's possible this is an issue in the integration of the rules_closure ClosureWorker harness with a more...

Thanks for the tip! Strangely, the MediumPicker source is not present even after first (parseInputs) pass. It got all the way to whatever pass is after earlyPeepholeOptimizations before aborting with...

Oh, I thought that the `goog.declareModuleId` was allowed to be used as an entry_point. This code currently works with an older Compiler, so the behavior must have changed. Are you...

Yeah, I apologize for the vague bug report. I think I did get a simple reproducer that demonstrates the NPE as contrasted with an earlier closure compiler. Thanks for your...

Ah, thank you for the explanation, and sorry for wasting your time prior to finding a good reproducer!

The need to annotate tuples comes up constantly when using React hooks (React.useState). This capability would be extremely useful. ref: https://groups.google.com/g/closure-compiler-discuss/c/MsoqyuVZL1M/m/lOhWU6R8CAAJ

Thanks for the guidance. Since calling React.useState is a common thing to do, I was hoping to make it possible to do so with less ceremony. Going through a wrapper...