Rob Figueiredo

Results 128 comments of Rob Figueiredo

I don't have a benchmark setup or any code to share, sorry. The code was the trivial code you might expect -- a loop repeatedly calling `FetchMessage` or `ReadBatch` to...

We have an internal bazel rule for running wire, by setting up a GOPATH using the go_path rule and running the usual wire binary. https://github.com/bazelbuild/rules_go/blob/master/go/private/tools/path.bzl#L155 It works, but it is...

Test added, but that reminded me of a lingering problem -- moduleLoad error always fires spuriously. Since moduleLoad seems to be redundant to strictDependencies, I suppressed it unconditionally. But probably...

Hm, I see similar `moduleLoad` suppressions in the ES6 tests in closure/compiler/test/strict_dependency_checking/BUILD, so that makes me think that it never worked. Perhaps the rules should just always suppress moduleLoad?

Opened an issue for the `moduleLoad` problem I'm not sure I understand your other comment -- perhaps `rules_closure` should not support extensionless imports, or perhaps the fix instead belongs somewhere...

@alexeagle any thoughts on getting this in? It seems pretty small / unobjectionable to me.

Extensionless imports are explicitly supported by Closure Compiler in NODE resolution mode, which is where I got the idea originally: https://github.com/google/closure-compiler/wiki/JS-Modules#node-resolution-mode I don't know the history or context behind them,...

Sorry, I missed your last response. Relevant link: https://nodejs.org/api/modules.html#modules_all_together I agree that your scenario is possible in theory, but it's not possible in practice because the LOAD_AS_DIRECTORY algorithm requires a...

Adding the type does fix this issue, so maybe that's the solution ``` /** * @const * @type {jQuery} */ var $ = jQuery; ```

Hi @jart , Would you accept a pull request adding this feature, and if so could you confirm exactly how you'd like it to look? I'm looking to migrate our...