Robert Osfield

Looking at the OpenEXR API it looks like 1 to 4 channel data should be possible, The current reading code is hardwired to single channel or RGBA I can't see...

I have refactored the vsgXchange::openexr::read(..) method to avoid code duplication and then added support for reading 2 and 3 channel images. [vsgXchange::openexr changes](https://github.com/vsg-dev/vsgXchange/commit/3d3ecb89f3c2156c75bbb0616a10c537c5748e52) When testing the OpnEXR test dataset I'm...

On Thu, 26 May 2022 at 07:26, Lachei ***@***.***> wrote: > Looking already quite good. If you want to use an even more general > solution i would suggest reading...

I have added try/catch blocks to vsgXchange::openexr which handles some cases, but am also getting a segfault inside openexr with a couple of the openexr tests image due toImf_2_5::ScanLineInputFile::readPixels not...

I have completed the work adding handling of invalid files and exceptions so am ready with merge the openexr branch with vsgXchange master. One open issue I haven't tackled yet...

I've reviewed the code and feel that the below change is appropriate: diff --git a/src/openexr/openexr.cpp b/src/openexr/openexr.cpp index 5bb9fee..06fc5ca 100644 --- a/src/openexr/openexr.cpp +++ b/src/openexr/openexr.cpp @@ -102,7 +102,7 @@ namespace }; virtual...

On Thu, 26 May 2022 at 14:36, Lachei ***@***.***> wrote: > Yes, your changes are appropriate. > That's a relief as I've already merged with vsgXchange master :-) There are...

Touching base once more as the VSG is steadily converging towards 1.0. I will spend some time this afternoon reviews the QueryPool functionality to see if it's appropriate for merging....

I've copied the files directly and created a branch from these changes, and assigned you as the original author: [https://github.com/vsg-dev/VulkanSceneGraph/tree/QueryPool](https://github.com/vsg-dev/VulkanSceneGraph/tree/QueryPool) I've also done various house keeping changes to the files...

I have created a vsgquerypool example that puts timing around the main RenderGraph: [examples/commands/vsgquerypool/vsgquerypool.cpp](https://github.com/vsg-dev/vsgExamples/blob/QueryPools/examples/commands/vsgquerypool/vsgquerypool.cpp) I still need to background reading on this feature, and fix the build on Android, but...