Roberto Rojas
Hey @jaxxstorm @luxas are you guys still looking into this?
I've been looking into this issue and here is one idea on addressing the build tag guard. I thought about creating 3 files like so: **libvirtgo.go** (this file contains implementation...
I'm getting closer to a PR for this issue. As for the dependency to the libvirt-go package, would Go 1.5+ vendoring suffice?
@mdlayher great points! Specially the use of interfaces for stubbing functions. I honestly didn't like my approach either, but no alternatives came to mind. I'll start working on this tonight.
@mdlayher any feedback on my latest commits?
@lukahn For whatever is worth, I've followed some of the advice on this video and worked for me: https://www.youtube.com/watch?v=V5sUYYXRJ6Q
It appears that the `request.Data` is already being used for the [body](https://github.com/dapr/components-contrib/blob/master/bindings/smtp/smtp.go#L111) of the email. I wonder if it makes sense to do the following instead: - If the contents...