go-qemu icon indicating copy to clipboard operation
go-qemu copied to clipboard

Published 20 hours ago • verified publisher icon digitalocean

Issue 30

Open robertojrojas opened this issue 8 years ago • 3 comments

Here is one implementation of the Monitor using the https://github.com/rgbkrk/libvirt-go package. Let me know if you there is anything you would like me to change.

robertojrojas avatar Oct 18 '16 23:10 robertojrojas

@mdlayher great points! Specially the use of interfaces for stubbing functions. I honestly didn't like my approach either, but no alternatives came to mind. I'll start working on this tonight.

robertojrojas avatar Oct 19 '16 14:10 robertojrojas

Sounds good. Apologies for all the comments; just trying to keep things consistent throughout the repo where possible.

mdlayher avatar Oct 19 '16 15:10 mdlayher

@mdlayher any feedback on my latest commits?

robertojrojas avatar Oct 27 '16 20:10 robertojrojas