Robert Long comments

Results 76 comments of


                                            Robert Long

Keyboard shortcuts

I think we can handle them with `window.addEventListener("keydown", onKeyDown)` etc. It won't work if the window isn't focused so you may still want to handle that, especially for something like...

updateMatrixWorld Optimization using new Object3DMatrixData class

This looks really interesting! One minor suggestion. Maybe call it `Transform` instead of `Object3DMatrixData`? @netpro2k @takahirox you may want to test this one out on Hubs without the current perf...

updateMatrixWorld Optimization using new Object3DMatrixData class

I'm not so sure the naming should imply that it's more public than it is. There's some precedent with `Source` which is a mostly internal API.

feature request: V6 needsApproval mid-execute instead of before execute

> > want to fetch some content from my database and update a component on the client with that data to be shown when the user is asked to Accept/Deny...

feature request: V6 needsApproval mid-execute instead of before execute

Yup, that would work. A little duplicative if the needs approval function uses an async method whose result is also needed in the execute function but I can cache it...

feature request: V6 needsApproval mid-execute instead of before execute

Oh yeah that's exactly what I've been looking for!