Robert Ancell

Results 106 comments of Robert Ancell

@stuartmorgan I have the tests passing locally, but there's this `TestDeviceException(Unable to start the app on the device.)` error on the CI - It's not clear to me what might...

The windows tests are failing with: ``` 00:02 +372 -4: test\pigeon_lib_test.dart: generator validation Error: C:\b\s\w\ir\x\t\74db0377/foo.dart: _ValidatorGenerator 00:03 +373 -4: test\pigeon_lib_test.dart: generator validation skipped ``` I'm not sure what's going wrong...

And I can't work out what is wrong with the Linux tests, the log says: ``` The following packages had errors: packages/pigeon See above for full details. ``` But I...

Ah, I thought they were passing locally but I didn't notice they were actually crashing in the same was as in the CI... Some challenges I've had running the tests:...

For example if I break a function signature like: ``` $ git diff ./platform_tests/test_plugin/linux/test/utils/fake_host_messenger.cc diff --git a/packages/pigeon/platform_tests/test_plugin/linux/test/utils/fake_host_messenger.cc b/packages/pigeon/platform_tests/test_plugin/linux/test/utils/fake_host_messenger.cc index b78301cec..3edee14e6 100644 --- a/packages/pigeon/platform_tests/test_plugin/linux/test/utils/fake_host_messenger.cc +++ b/packages/pigeon/platform_tests/test_plugin/linux/test/utils/fake_host_messenger.cc @@ -149,7 +149,7 @@ static...

You need to change `.where((properties) => properties.contains('powered'))` to use the capitalized property name `"Powered".

I haven't investigated this but it seems to be a general issue following the link above.

I'm not sure if this is required - the windows examples don't seem to mention the runner directory.

> @robert-ancell, the PR was merged back in September, but I gather it's not in the stable release yet? Correct, this is not in stable yet.

@chinmaygarde would love some help on how the gn rules should look!