Robert Jonsson

Results 25 comments of Robert Jonsson

I have the same problem with my Pixel 6 running Android 14. From Android 13 the `onBackPressed` method (that this app uses to exit) is deprecated and should not be...

I have made some tests and using androidx.activity.OnBackPressedCallback (and OnBackInvokedCallback in SettingsActivity) seems to fix the issue. I can make a PR I you want to have a look/try.

Unfortunately, using OnBackPressedCallback/OnBackInvokedCallback did not solve the issue after all. During my tests, I had enabled the [Predictive back animations](https://developer.android.com/guide/navigation/custom-back/predictive-back-gesture) feature on my device (Settings > System > Developer options)....

> Only TabActivity and SettingsActivity remains, which is quite some changes. I have been working on migrating all settings to AndroidX Preferences. Before I make a PR I wonder if...

> The recommended handling for settings is not to have it in the toolbar. I'm not sure I understand. Or perhaps we misunderstand each other? Why not like in the...

@gerhardol, have you or anyone else started any work to replace TabActivity? If not, I can give it a try.

> Potentially the same in Encryption encrypt (only 8 bytes, probably OK) and ManageWorkoutsActivity (saveImport not common) Yes, definitely the same in ManageWorkoutsActivity. Should I edit this PR and make...

> You can add to this PR. OK, will do. >I have not checked where this PR change is actually used. FileUtil.copy is used from MainLayout.handleBundled to import workouts/schemes from...

> There are two occurrences each in app/src/main/org/runnerup/tracker/component/TrackerPebble.java:85... I agree, this we should change. But I'm unsure why LocalBroadcastManager is used to broadcast RESUME_WORKOUT and PAUSE_WORKOUT and context.sendBroadcast() is used...

> ... and app/src/main/org/runnerup/tracker/component/TrackerPebble.java:479 I assume you mean app/src/wear/org/runnerup/tracker/component/TrackerWear.java:479? I agree, but same question here. Do we use contextsendBroadcast() or LocalBroadcastManager?