jonasoreland
Replace TabActivity with AppCompatActivity
TabActivity has long been deprecated, and its use prevents niceties from the support library—vector drawables, for example.
Please use AppCompatActivity for MainLayout and fragments for its individual components (StartActivity, FeedActivity, HistoryActivity, SettingsActivity).
All of this is supported on Froyo, so there should be no compatibility issues.
A partial conversion to AppCompat is available in branch: https://github.com/gerhardol/runnerup/tree/feature/appcompat-changes
Migration to androidx and AppCompatActivity done where possible. Only TabActivity and SettingsActivity remains, which is quite some changes.
Only TabActivity and SettingsActivity remains, which is quite some changes.
I have been working on migrating all settings to AndroidX Preferences. Before I make a PR I wonder if there is some special reason why the SettingsActivity has no Toolbar (app bar)? Both StartActivity and HistoryActivity have one.
Should we add a Toolbar to SettingsActivity as well?
Only TabActivity and SettingsActivity remains, which is quite some changes.
I have been working on migrating all settings to AndroidX Preferences. Before I make a PR I wonder if there is some special reason why the SettingsActivity has no Toolbar (app bar)? Both StartActivity and HistoryActivity have one.
Should we add a Toolbar to SettingsActivity as well?
No specific reason, it just happen to be this way....
The recommended handling for settings is not to have it in the toolbar. But with only two other tabs, it is not a space issue.
Looking forward for this - I have gotten stuck every time I started.
The recommended handling for settings is not to have it in the toolbar.
I'm not sure I understand. Or perhaps we misunderstand each other? Why not like in the right picture?
Looking forward for this - I have gotten stuck every time I started.
Looking forward for your feedback. =)
The recommended handling for settings is not to have it in the toolbar.
I'm not sure I understand. Or perhaps we misunderstand each other? Why not like in the right picture?
My comment was related to Settings as a tab is not recommended.
Add the app bar...
@gerhardol, have you or anyone else started any work to replace TabActivity? If not, I can give it a try.
@gerhardol, have you or anyone else started any work to replace TabActivity? If not, I can give it a try.
No, I have not tried that. I am not aware that anyone else is working on that. It would be welcome!
@roberi If you see any inconsistencies and improvements, just fix them. The GUI could be improved...