Robert Shepherd

Updated types from unknown and removing unused variables

7

* Starting to move types across. * Tests will fail due to types not being correct in `node-sinek` Which leads me to the next part of updating `node-sinek` in kafka-streams....

based on: https://kafka.js.org/docs/configuration and https://github.com/tulios/kafkajs/issues/298 We may not have the correct settings for the JSConsumer and JSProducer. This issue is to ensure we have them up to date after https://github.com/nodefluent/node-sinek/pull/154...

Opening an issue here to have discussions on moving from yarn to npm. Some benefits of yarn: * Pinned Version Resolutions * Speed * yarn2 - https://github.com/yarnpkg/yarn/issues/6953

Coupon X get Y free - multiple coupons

3

I have found an issue when you have multiple coupon codes separated by a comma only the first coupon gets used. On line 297 of the controller your only passing...

Updated the controller to now accept multiple coupon codes.

Feature: Allow seek by timestamp.

1

KafkaJS allows seeking to a topic's offset via timestamp: https://kafka.js.org/docs/admin#fetch-topic-offsets-by-timestamp This would be great addition to the seek options: https://github.com/rob3000/nestjs-kafka/blob/master/src/kafka.service.ts#L207