Robert Shepherd

Results 35 comments of Robert Shepherd

Hi @maikelmclauflin , Are you able to provide some code samples so we can replicate it?

+1 for this @wtrocki i've already start converting node-sinek in this pr: https://github.com/nodefluent/node-sinek/pull/154

Hey @johnhalbert the suggestion looks good! One thing to note is that we have started to move the repo over to typescript and are just waiting on the following PR...

Hi @zeeshanalisyed thanks for the report. Are you able to provide me with a code sample of what you have so we can replicate it?

@wtrocki whats the best way to introduce those sinek changes? Assuming merge this in ASAP then update?

@wtrocki the only item outstanding is the failing tests so want to make sure the conversation to Typescript hasn't broken anything

Currently need the following PR: https://github.com/nodefluent/node-sinek/pull/161 to be merged to include an alpha build of sinek for this PR.

Finally managed to spend some time looking into the failing tests 🎉 So with the alpha version of sinek, it now uses kafkaJS as the client. This means some of...

Hi @cnwme , Are you able to provide more context and some code examples of what you are trying to achieve?

Thanks for the info @cnwme i'll take a look into this shortly.