Ryan Oaks comments

Results 143 comments of


                                            Ryan Oaks

Created new resources: RegionSecurityPolicy and NetworkEdgeSecurityServices for google_compute_security_policy , google_compute_region_security_policy and google_compute_network_edge_security_services to support Cloud Armor

/gcbrun

Created new resources: RegionSecurityPolicy and NetworkEdgeSecurityServices for google_compute_security_policy , google_compute_region_security_policy and google_compute_network_edge_security_services to support Cloud Armor

/gcbrun

Created new resources: RegionSecurityPolicy and NetworkEdgeSecurityServices for google_compute_security_policy , google_compute_region_security_policy and google_compute_network_edge_security_services to support Cloud Armor

This is blocked on failing tests

Adding support for Org policy custom constraints

/gcbrun

Adding support for Org policy custom constraints

Overall code looks good to me, and the changes make sense to me as an add-on of the initial Terraform implementation of this resource. Note that this repo should autogenerate...

Multicast domain activation

/gcbrun

Create ServiceConnectionPolicies and ServiceClass resources for NetworkConnectivity products.

Note that ServiceConnectionPolicies was added by the linked PR, but ServiceClass is still not implemented.

The certificate_manager_certificates in google_compute_region_target_https_proxy can't remove the useBy when change value to null

I reproduced these steps and did not get the erroneous result of the `google_certificate_manager_certificate` still being flagged as `usedBy`. I used a config closer to our docs examples that included...

The certificate_manager_certificates in google_compute_region_target_https_proxy can't remove the useBy when change value to null

@ThuanNguyen123456 I'm still having trouble reproducing this issue, including using conditions in the logic as you mentioned. Are you able to reproduce this within an arbitrary environment, or are you...

fix: if unable to calculate local md5 hash use old value of detect_md5hash

Yea, this is relatively complicated. The `detect_md5hash` solution seems to fundamentally be at odds with Terraform paradigms (see https://developer.hashicorp.com/terraform/plugin/sdkv2/guides/terraform-0.12-compatibility#inaccurate-plans), in that it is explicitly communicating a planned value of `different...