Ryan Oaks

Results 143 comments of Ryan Oaks

Oh and yes, I'm reviewing the bugs you listed next, and I don't think you need to rebase.

I would recommend a minimal `linux_node_config` update test to verify it can be updated successfully. So maybe just a single subfield. Reviewed related issues and added some notes, but overall...

Hi @BIwashi , this is great info that you've provided! Normally, we would capture the problem in an issue, so that it is searchable by other people, and we can...

Per https://github.com/hashicorp/terraform-provider-google/issues/13584#issuecomment-2314568353, we probably won't need this now that gcloud has been updated, but I will leave it open for just a bit longer to confirm.

Over the last 2 months, this is actually incredibly rare. When it does occur, it looks like it normally is only one of these tests (or the *policy test), but...

Actually, this might have just been a weird ordering of GitHub comments. Let me try just a fresh run of the checks.

Note: the issue with the initial implementation (https://github.com/GoogleCloudPlatform/magic-modules/pull/5008) was just that: the field appeared as configurable in the API docs, but seemed to not be working. Unless someone can confirm...

Follow-up note: this should be changed to point to the feature branch since it is a breaking change (see https://googlecloudplatform.github.io/magic-modules/develop/breaking-changes/make-a-breaking-change/)