Created new resources: RegionSecurityPolicy and NetworkEdgeSecurityServices for google_compute_security_policy , google_compute_region_security_policy and google_compute_network_edge_security_services to support Cloud Armor

[fernandoleonem]

API: https://cloud.google.com/compute/docs/reference/rest/beta/securityPolicies

Cloud Armor for NLB/VMs APIs

1. New resource NetworkEdgeSecurityServices

2. New ddosProtectionConfig fields in SecurityPolicies

3. SecurityPolicyType: CLOUD_ARMOR_NETWORK

If this PR is for Terraform, I acknowledge that I have:

• [x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• [x] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• [x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• [x] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• [x] Read the Release Notes Guide before writing my release note below.

compute: Created new resources: RegionSecurityPolicy and NetworkEdgeSecurityServices for google_compute_security_policy , google_compute_region_security_policy and google_compute_network_edge_security_services to support Cloud Armor (beta)

[afpesseti]

Hello @roaks3, how are you? We've some problem with generate-diffs and run-rake-tests, we already got this problem previously, the reviewer ran the command \gcbrun and it worked. We try to run the same command, but it didn't work, I think we don't have permition to do this. Could you help us please? This new changes are google internal request.

[roaks3]

Oh sure, sorry for the delay. Running the checks now.

[roaks3]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 377 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 9 files changed, 1890 insertions(+), 79 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2477 Passed tests 2216 Skipped tests: 255 Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeRegionSecurityPolicy_update|TestAccComputeRegionSecurityPolicy_basic|TestAccComputeNetworkEdgeSecurityServices_withRegionSecurityPolicy|TestAccComputeNetworkEdgeSecurityServices_basic

[modular-magician]

Tests passed during RECORDING mode: TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Debug log] TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode: TestAccComputeRegionSecurityPolicy_update[Error message] [Debug log] TestAccComputeRegionSecurityPolicy_basic[Error message] [Debug log] TestAccComputeNetworkEdgeSecurityServices_withRegionSecurityPolicy[Error message] [Debug log] TestAccComputeNetworkEdgeSecurityServices_basic[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

[afpesseti]

/gcbrun

Thank you again! I made some changes, can you run again?

[roaks3]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 377 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 9 files changed, 1890 insertions(+), 79 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2484 Passed tests 2223 Skipped tests: 255 Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeRegionSecurityPolicy_update|TestAccComputeRegionSecurityPolicy_basic|TestAccComputeNetworkEdgeSecurityServices_withRegionSecurityPolicy|TestAccComputeNetworkEdgeSecurityServices_basic|TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample|TestAccFirebaserulesRelease_BasicRelease

[modular-magician]

Tests passed during RECORDING mode: TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode: TestAccComputeRegionSecurityPolicy_update[Error message] [Debug log] TestAccComputeRegionSecurityPolicy_basic[Error message] [Debug log] TestAccComputeNetworkEdgeSecurityServices_withRegionSecurityPolicy[Error message] [Debug log] TestAccComputeNetworkEdgeSecurityServices_basic[Error message] [Debug log] TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[roaks3]

This is blocked on failing tests

[rileykarson]

Hey! I'm closing this PR as a part of a cleanup of older inactive PRs, using a threshold of PRs last updated over 3 months ago. This doesn't represent rejection of the change, and feel free to comment for me to reopen it if you plan to pick it back up, or feel free to start a new PR with the same changes in the future.