Results 507 comments of rnveach

Similar to https://github.com/checkstyle/checkstyle/issues/3955 , I also feel allowing `STATIC_IMPORT` to be optional is a bug and the check does not really handle the situation appropriately. I could see some arguments...

@AustinShalit Issue is closed and check is already implemented in sevntu. There is no plans to move checks at this time, especially since we are in the middle of GSoC.

@AustinShalit Once you add the check to checkstyle's code. Our unit tests and CI will guide you on pretty much everything that is needed. Checkstyle will require documentation for it...

@Shaman20 Do you still need assistance?

CI Failure: https://github.com/checkstyle/checkstyle/actions/runs/3092656103/jobs/5004176175 ```` Caused by: java.lang.ClassNotFoundException: com.puppycrawl.tools.checkstyle.api.AutomaticBean$OutputStreamOptions at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass (SelfFirstStrategy.java:50) at org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass (ClassRealm.java:271) at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass (ClassRealm.java:247) at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass (ClassRealm.java:239) at org.apache.maven.plugins.checkstyle.AbstractCheckstyleReport.getConsoleListener (AbstractCheckstyleReport.java:685) ```` https://github.com/apache/maven-checkstyle-plugin/blob/627fa4f684866a579f2c105fcc1dbf3ed776daa8/src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java#L63 https://github.com/apache/maven-checkstyle-plugin/blob/627fa4f684866a579f2c105fcc1dbf3ed776daa8/src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java#L686

It looks like this usage is preventing us from fully separating the classes like planned as we are completely reliant on this maven plugin and have not severed times with...

> Should I also deal with Checker-Framework errors? I am not really a fan of checker, so I would concentrate on it's failures last. It looks like pitest is failing,...

@stoyanK7 The compilation error changed, it isn't the same issue, so you'll need to look at what we need to do to make it pass. All these compilation errors seem...

> We have explicit import at [CheckstyleViolationCheckMojo.java#65](https://github.com/apache/maven-checkstyle-plugin/blob/b07adb2e51d6b016dd564893685f46b33fffe5db/src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo.java#L65) > no-error-methods-distance The main difference I am seeing between these is that methods-distance extends `DefaultLogger` while the others just instantiate `DefaultLogger`. When I...