rnveach

@romani This has already been rebased (2 days ago).

You can ignore IDEA, it is faulty right now. Let us know when you are ready for this PR to be reviewed.

This change will break maven checkstyle: https://github.com/apache/maven-checkstyle-plugin/blob/ab6a941b61e49fe114c00c3ce412d6b985c95df7/src/main/java/org/apache/maven/plugins/checkstyle/exec/CheckstyleCheckerListener.java#L42 eclipse-cs seems fine. We will have to create new class with old name and mark it deprecated and rename old class to new...

Nothing has been said that would say otherwise.

@Rahulkhinchi03 This issue should be very similar to https://github.com/checkstyle/checkstyle/issues/2551 . Both renamed classes to others and marked the old names as deprecated and were eventually removed.

There is a secondary issue where we don't initialize new locale right away. Exceptions and probably other things who try to print localized messages will use the default locale before...

I would consider a test field immutable only if it's value never changes throughout the life of the test run, including the place where it got its value from. If...

2 items were not done at https://github.com/checkstyle/checkstyle/issues/12099#issuecomment-1233749876

> Checks have all private fields. > I pretty sure it is covered by our modifier Check. Which one https://checkstyle.org/config_modifier.html ? > No check subpackage should depend on each other....

```` [INFO] --- spotbugs-maven-plugin: 4.7.2.0:check (default) @ checkstyle --- [INFO] BugInstance size is 1 [INFO] Error size is 0 [INFO] Total bugs: 1 [ERROR] Medium: Public static com.puppycrawl.tools.checkstyle. ConfigurationLoader. loadConfiguration...