rnveach
rnveach
This was not handled/discussed in https://github.com/checkstyle/checkstyle/issues/7602 (documentation update) . Since the check first introduced in 59222296258fecc02db44eeae1cb65b44b68c267 , `VARIABLE_DEF` was a default token alone. It was in 6125beffc437f970eae276b4a6542265c6547784 that `ENUM_CONSTANT_DEF` was...
IMO, I think this check has expanded such that it should be customizable to disable/enable either one of the tokens or both. It is like JavadocMethod where multiple token combinations...
```` $ cat TestClass.java public class TestClass { public int field; public enum TestEnum { MY_CONST; } } $ cat TestConfig.xml $ java -jar checkstyle-10.3.2-all.jar -c TestConfig.xml TestClass.java Starting audit......
@romani > can you send PR to https://github.com/sevntu-checkstyle/checkstyle-samples/tree/master to have one more example for ant, and CI will keep it up to date. How should we handle bringing in the...
@romani samples is already using a sevntu ant. Sevntu config. https://github.com/sevntu-checkstyle/checkstyle-samples/blob/master/ant-project/checkstyle.xml#L10 Sevntu maven. https://github.com/sevntu-checkstyle/checkstyle-samples/blob/master/ant-project/ivysettings.xml#L13 Sevntu dependency. https://github.com/sevntu-checkstyle/checkstyle-samples/blob/master/ant-project/ivy.xml#L6 Sevntu being pulled in by lib from ivy. https://github.com/sevntu-checkstyle/checkstyle-samples/blob/master/ant-project/build.xml#L30 https://github.com/sevntu-checkstyle/checkstyle-samples/blob/master/ant-project/build.xml#L36-L37 https://github.com/sevntu-checkstyle/checkstyle-samples/blob/master/ant-project/build.xml#L18
GitHub, generate website
@romani I confirmed the example works by first running `checkstyle ant` in `checkstyle-samples` (to pull down depdendencies and setup lib folder) and running it with the following build XML: ````...
technically yes, but you really aren't gaining much more. Yes, your specifying custom location for sevntu, but your classpath much set up already for checkstyle since it requires all it's...
@ZuevKirill95 Please move important details here. This should include why this is wanted, proposed method signature, note about scope of change (lots of checks were changed), etc...
This is looking similar to https://github.com/checkstyle/checkstyle/issues/3955#issuecomment-1229118066 , `STATIC_IMPORT` token was added at 6125beffc437f970eae276b4a6542265c6547784 as a default token. Acceptable tokens was clarified at abe2b200312ee72aa552026b1a34e8bd72bfdc4e that both should be acceptable. It wasn't...