Results 486 comments of rnveach

@Bananeweizen As I mentioned in https://github.com/checkstyle/eclipse-cs/issues/465 , this needs to be a bigger question of the overall flow of things in both repositories. Eclipse-CS is not using the Checkstyle library...

One issue you will run into is https://github.com/checkstyle/eclipse-cs/issues/465 . Eclipse-CS' current caching method is incomplete and causes issues. Adding a new cache on top of it will make figuring out...

> The existing lifecycle of the cachefile in checkers doesn't really fit for the plugin, therefore it currently calls the persist method via reflection. IMO, I feel Eclipse-CS is not...

> I think HTML validation should be a separate check. This check extends `AbstractJavadocCheck` which uses the Javadoc parser. HTML and Javadoc parsing are all in one, there is no...

Edit: I am removing this. Property is additive, not either/or.

Latest review discussion is at https://github.com/checkstyle/checkstyle/pull/14734#discussion_r1597719839

> Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: IllegalStateException occurred while parsing file xyz.java > Caused by: org.antlr.v4.runtime.NoViableAltException This is a checkstyle issue, not a sonar checkstyle issue. Either your Java file is not...

The checkstyle files will also have to be reviewed as per https://github.com/checkstyle/eclipse-cs/issues/351

Thank you. I am unsure which option you mean for `fps report interval`. I assume this isn't MAX_RESTART_DELAY?