rnveach
rnveach
Closing this. Please create a new PR with other admins as the reviewers. https://github.com/checkstyle/checkstyle/issues/15643#issuecomment-2336777333
@mahfouz72 This tracker issue is now approved. Please keep this issue up to date on what will be spawning connected to this issue from here on out. For example, now...
I would report an issue to sevntu if you think it is a bug in the check.
> Not sure if it's confused by the "m" notation I think this is the issue. My understanding of the check, from just refreshing my memory, is (for example) a...
@Bananeweizen I apologize, `SimpleAccessorNameNotationCheck` does have a prefix property. However, I believe it only supports one type of prefix, so if eclipse-cs uses multiple then it won't work. ```` $...
@romani @nrmancuso https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e53d9a2_2024010200/reports/diff/checkstyle/index.html#A3 https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e53d9a2_2024010200/reports/diff/checkstyle/index.html#A8 https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e53d9a2_2024010200/reports/diff/checkstyle/index.html#A10 Regression found an exception. ~@mahfouz72 Move exception in master to new issue. Our checks should not throw an exception on compilable code.~ Edit: https://github.com/checkstyle/checkstyle/pull/15166#issuecomment-2198159827 >...
Maybe I am not finding all the regressions. I should see regression of: * Base is default with all tokens, Patch is default with `ignoreUnnamedParameters` set to true with all...
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/22a829d_2024194022/reports/diff/index.html Change in exceptions is fine. I am asking more questions outside of this. https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/22a829d_2024183400/reports/diff/index.html https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/22a829d_2024183400/reports/diff/openjdk17/index.html#A2 This is an interesting case. Method parameters can't be unnamed, but this file isn't...
> Only after purging the cache (ctrl-3, purge) and saving again the added/removed comment will have an effect Unless you are using Checkstyle's cache file system ( https://checkstyle.org/config.html#Checker_Properties ), this...
> Check not only whether the file is still the same, but also read the filetext again and compare that to a cached version The purpose of this check was...