rnveach

You can also override Checkstyle's message with your own. https://checkstyle.org/checks/naming/illegalidentifiername.html#Violation_Messages

I think current message is good and clear. Says who is at fault and what they need to do to resolve the issue. You can't remove the "regexp" part of...

> Identifier 'var' matches illegal pattern This is not an `illegal` pattern. Users must enter acceptable pattern into config. https://checkstyle.org/checks/naming/illegalidentifiername.html#Properties I am fine with changing `Name` to `Identifier` in message,...

https://checkstyle.org/checks/naming/constantname.html#Properties We have been using properties like this since the beginning of time (above is 3.0 example), and I don't remember any issues of anyone complaining about this formatting until...

I also want to remind that longer file names is not always good. Windows constraints is putting some of its users on edge of not being able to clone the...

Edit, this is not the right issue.

This is a duplicate of https://github.com/checkstyle/checkstyle/pull/14214/files but this PR at least starts on a reasoning which is what the other was waiting on. @Rohanraj123 Can you clarify where the replace...

Then I don't understand this PR with your newest change. Why would trim fail pitest but replaceAll would pass? They seem to be virtually the same thing, and I wouldn't...

```` new OutputStreamWriter(null, StandardCharsets.UTF_8); Exception in thread "main" java.lang.NullPointerException at java.base/java.io.Writer.(Writer.java:174) at java.base/java.io.OutputStreamWriter.(OutputStreamWriter.java:126) ```` `infoStream != errorStream` for this to be hit. The IAE was the only thing blocking it.

That is not an explanation of the code and why this change is ok. It just shows that we couldn't find anything in our pre-sets that this change had an...