Results 508 comments of rnveach

I am still not following. You say our code/logic is correct, but then go on to say it isn't correct for this check. If we need an override, then either...

> Why can't we correct code when field can not be found to display blanks instead of null? > it will affect bunch of other Checks that already expect null...

To me, everything I said above is the same but now pointed at `PROPERTY_SPECIAL_DEFAULTS`. If `null` isn't valid, then we shouldn't display it for any of the others.

The difference in a suppression is we don't have to change any code to suppress. Here we have to create a workaround, and I don't agree with it as we...

https://github.com/checkstyle/checkstyle/pull/14217#issuecomment-1879912059 > then https://github.com/checkstyle/checkstyle/pull/14180 is mostly obsolete except the macro conversion

So then you understand why this PR is still awaiting changes?

> is present only due to this defect. Even so, this workaround must stay because even this method can fail.

https://github.com/sevntu-checkstyle/checkstyle-samples Every folder you see besides CI and GitHub. CI folder can be used to duplicate it's CI into our own.

Those existing maven ones will have to be converted to CLI when we start to break compatibility with it.

I did not really see us covering out maven sample. Regressions will move off maven to continue having regression. Maven sample could be out last item to stay as maven...