rnveach
rnveach
@romani 2 CI failures do not look related to the code in this PR. First one doesn't show a failure, other is our limit is exceeded.
@Zopsss @nrmancuso Please make sure the URLs you are using are https://checkstyle.org/ and not sourceforge. The only thing sourceforge supports that our main doesn't still is version history which I...
@Zopsss No one likes the constant pinging and I would consider it rude. Not all of us live in GH to respond to every message every day. This is not...
> I generated two report If you are going to give this summary for reviewers, I highly recommend you copy the report links too. This helps that we don't have...
I believe the issue with the counter, is at https://github.com/checkstyle/checkstyle/blob/ee700b71b5414720afec1a2e38c7b8b1f77a7813/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/VariableDeclarationUsageDistanceCheck.java#L397 . When we reach a block and calculate the distance, we ignore previous lines as we assign the distance and...
@GitToasterhub > So,whe distance should be 5 if real distance is 9?? there 9 statements between initialization of t and first usage of it. We don't count variable definitions in...
> should empty space be counted as a distance unit or not, @GitToasterhub I assume you mean completely empty lines or comments. The answer is no. This check only counts...
If the above report is still valid with newer versions of CS, then the issue is valid unless something has been posted to change. My first post explains why I...
> when I turn on the property it reported the same violation that you expected https://checkstyle.org/checks/coding/variabledeclarationusagedistance.html#Example4-code This is why I don't want to turn the property on. As shown in...
@MANISH-K-07 Issue needs to be approved first before work can be started. The only other option is admins giving approval to work on something without the approved label, but approval...