Results 94 comments of rmsyn

> Rust nightly is complaining about a bug in LLVM for inline assembly with x86 targets One potential way to solve that issue before the fix makes it into a...

> The thing is that it still complains for RISC-V targets :/ What about switching the label to `1b:`, `b1:`, or something similar? Not sure about any concern for label...

Right, we discussed working on something like `aarch64-rt` in the Matrix room, but I've since had focus shifted to other work. Would you be interested in using/working on an `aarch64-rt`...

> BTW, I added missing changelog for CounterMask structure in this commit: https://github.com/rustsbi/rustsbi/commit/232b3d7b3036eeeb0d7bdb353e7d44f93ca71fb3 . Next time we should remember to write a changelog when we contribute, or it's easy to...

> @rmsyn: sbi-spec version 0.0.8-rc.1 is released ([crates.io](https://crates.io/crates/sbi-spec/0.0.8-rc.1), [documents](https://docs.rs/sbi-spec/0.0.8-rc.1)). Please check if the version 0.0.8-rc.1 meets our demands (e.g. is the functions in CounterMask correct?); if it's correct, I'll formally...

> As per https://github.com/rust-embedded/riscv/issues/247, using weak symbols for overridable functions has proven problematic with lto = true. Is this only a problem with `rust-lld` (read `lld`)? If so, does using...

> I think I prefer this approach of no-symbol features instead of using default features. With the no-symbol scheme, crates can explicitly drop parts of the riscv-rt crate. I'm not...

> To clarify the situation, because, as @ia0 said, I'm not sure if additive/subtractive is a good terminology: > > In `riscv-rt` we **need** an `abort` routine to make our...

> It's true that for methods and functions (outside traits), a feature adding that method or function is additive. However this is not the case for trait methods and symbols...

> Did you get a chance to read https://github.com/rust-embedded/embedded-hal/blob/master/docs/how-to-add-a-new-trait.md? Not yet, I missed it before opening the PR. Going over it now. > This PR is missing some background work,...