Robert Mosolgo

Results 408 comments of Robert Mosolgo

Thanks for reporting this -- agreed that it sure doesn't _seem_ like it should work this way. I agree that it'd be a good candidate for 3.x. I'm hoping to...

Hey @gmac, I'm not sure I totally understand... On these to points: > tossing depth recursion and running `evaluate_...` ... on a tight loop and > switching to a batch...

Sad, it seems like the test suite hangs now...

Ok, I think the problem was that Fiber / Task nesting. I reworked it so that each pass over the set of pending dataloader fibers spins up a new job....

I saw that error, too, and assumed that GraphQL was "working," since it called code as expected. Inspecting the dataset, I see that it was passed the right values: ```...

Interesting -- a change like that puts `Async` primitives back inside a plain Ruby `Fiber.new { ... }`, further suggesting that's the origin of the issues here. It might be...

There's still a _lot_ to do here for compatibility and performance, but the initial benchmark results are surprisingly good (even with the terrible `FieldResolutionStep` implementation which is hogging memory). This...

I haven't pushed a commit here for a while but I'm still planning on landing this somehow. Here's a quick brain-dump in case anyone is curious: - The perf win...

Hey, thanks for the detailed report -- I'll take a look soon and follow up here!

👋 I made some time to investigate this issue. I think GraphQL-Ruby is confused by the second argument to `field ...`, which is `"test"` in the example code above. It's...