Robert Mosolgo

Results 344 comments of Robert Mosolgo
trafficstars

Ah... yes, there is a setting there: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#controlling-changes-from-forks-to-workflows-in-public-repositories I switched it so only "new GitHub accounts" need me to approve them. Hopefully that will do it 🤞

👋 Sure thing. I'd be happy to take care of the C-Parser changes whenever the Ruby implementation is ready to go. Or, if you're interested in investigating it yourself, I...

Happy to! Thanks for all your work on this feature so far 🍻

I did some updates to the C parser to accept comments in https://github.com/rmosolgo/graphql-ruby/commit/a70db539cc55923e8b59afa02bbf2a5add482242 (I would have pushed it to your branch but it looks like "allow commits from maintainers" isn't...

:+1: Sounds good to me to reduce the scope of this change to only go Ruby-to-GraphQL. I forgot that was the _real_ goal here 😅 If we want to add...

Thanks again for all your work here ... and sorry I sent you down a road to nowhere 😖!

Hey, thanks for the detailed write-up. I'm definitely open to exploring options for loading the schema as-needed. Currently, _any_ GraphQL query loads the entire schema, because, as you noticed, `query(...)`...

👋 I'm gearing up to take a try at this. You mention something that's halfway there -- have you had any luck in your approaches to this change?

I'm starting on this in #4974. So far I've done the bare minimum: delay calls to `add_type_and_traverse` until the result of that traversal is actually needed. This will put off...