Rafał Miłecki
Rafał Miłecki
Looks fine I guess.
I think the same feature was requested in the https://github.com/invoice-x/invoice2data/issues/238. I don't think YAML (or Python's dict) allows using the same key multiple times. That would also require picking some...
Please reopen if you decide to get back working on this :)
I'm quite a bit confused by this pull request. I'm not sure what does it do and what are you trying to fix/improve. 1. A single commit modifying hundreds of...
@bosd: I feel you really don't like the new syntax, I'll have to argue a bit here. > I would vote against the "new" syntax, because of breaking compatibility While...
You spent quite some time criticizing the new syntax but not so much explaining your changes. Can we take a step back and discuss **what** do we need to support,...
> Moi point is aimed more at a comment the "old" syntax should be phased out in a year. Good point! Given how little maintainance it takes to keep old...
I'll try to review this this Sunday (Cc @m3nu)
This pull request rewrites a lot of `src/invoice2data/extract/parsers/lines.py` code and is really hard for me to review properly. It also modifies `parsers` code to while focusing on syntax handled by...
I've clearly missed some requirements, it seems we have a bit different cases after all. I'll spend some time analyzing this today and tomorrow and come back to you. Sorry...