Rafał Miłecki

Results 156 comments of Rafał Miłecki

@bosd: OK, I just found it's about `QualityHosting.pdf`. That problem you reported - about parsing `lines` in `QualityHosting.pdf` - is caused by the way `src/invoice2data/extract/templates/de/de.qualityhosting.yml` is constructed. It has nothing...

@bosd: in your analysis of `\s+` treating I think you misread input invoice. That `line: '^\s+(?P.+)$'` in `de.qualityhosting.yml` works as you expected. It matches only those lines that start with...

@bosd: so could we have this one merged now, please? It's a clear implementation, solves actual problem you reported, doesn't seem to regress anything. I find it a nice feature....

Please clean up those commits (there are 6 commits right now - 2 merges in it) and merge! :)

I'll review some of pending pull requests this weekend.

@bosd: I'll use this branch & pull request to collect & verify our expectations for the extended `lines` syntax I'll keep working on this during next days, please give me...

This is alternative implementation of feature suggested in the https://github.com/invoice-x/invoice2data/issues/377 This should resolve: https://github.com/invoice-x/invoice2data/issues/238 https://github.com/invoice-x/invoice2data/issues/377

@bosd: I think this implementation is a bit simpler than the one suggested in the https://github.com/invoice-x/invoice2data/issues/377 . I hope my changes are rather simple to understand & review. An advantage...

I need to rework this. Describe better, provide use case, test, probably avoid modifying Amazon YAML as there is no strong reason for this. Converted into draft for now. I...

This feature was requested by @noxqs in the https://github.com/invoice-x/invoice2data/issues/372 I added new test to: 1. Make this use case easier to understand 2. Make sure it gets tested, it works...